NwHIN PD can have invalid creation time

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

NwHIN PD can have invalid creation time

Daniel Kaplan
I would have liked to have created an issue for this, but after I created a jira account, I didn't see an obvious way to create an issue in there.

Sample:
	<PRPA_IN201305UV02 xmlns="urn:hl7-org:v3"
		xmlns:ns2="http://www.w3.org/2005/08/addressing" xmlns:ns3="urn:gov:hhs:fha:nhinc:common:nhinccommon"
		xmlns:ns4="urn:gov:hhs:fha:nhinc:common:patientcorrelationfacade"
		xmlns:ns5="http://www.hhs.gov/healthit/nhin" xmlns:ns6="urn:oasis:names:tc:ebxml-regrep:xsd:rim:3.0"
		xmlns:ns7="urn:oasis:names:tc:ebxml-regrep:xsd:rs:3.0" xmlns:ns8="urn:oasis:names:tc:ebxml-regrep:xsd:query:3.0"
		ITSVersion="XML_1.0">
		<id extension="-5a3e95b1:11d1fa33d45:-7f9b" root="HCID" />
		<creationTime value="2014321184955" />


The issue here is that the month field (32) is incorrect. We maybe somehow are taking out a 0 that is supposed to be... i.e. 20140321.... Is the 0 getting dropped out here?

I think the code that's causing this is in gov.hhs.fha.nhinc.mpi.adapter.component.hl7parsers.HL7DbParser201306#buildMessageFromMpiPatients line 137

If I run that code today (5/14/2014) it gives me a string of 2014514181346  That 5 should have a 0 in front of it.  Here's the code that's causing the problem:

    public static void main(String[] args) {
        String timestamp = "";
        try {
            GregorianCalendar today = new GregorianCalendar(TimeZone.getTimeZone("GMT"));

            timestamp =
                    String.valueOf(today.get(GregorianCalendar.YEAR))
                            + String.valueOf(today.get(GregorianCalendar.MONTH) + 1)
                            + String.valueOf(today.get(GregorianCalendar.DAY_OF_MONTH))
                            + String.valueOf(today.get(GregorianCalendar.HOUR_OF_DAY))
                            + String.valueOf(today.get(GregorianCalendar.MINUTE))
                            + String.valueOf(today.get(GregorianCalendar.SECOND));
        } catch (Exception e) {
            e.printStackTrace();
        }
        System.out.println(timestamp);
    }

I think a much more straight forward/idiomatic way to do this would be to use a SimpleDateFormat.
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Oh btw, this is in connect 4.2
Reply | Threaded
Open this post in threaded view
|

RE: NwHIN PD can have invalid creation time

matt w

Can you submit a patch with your proposed change in github? (https://github.com/CONNECT-Solution/CONNECT, submit the pull request to the CONNECT_integration branch). I agree with you in principal but Im a little fuzzy on where this is happening… I don’t believe a main() method would be called in any of our classes…

 

From: Daniel Kaplan [via CONNECT Forums] [mailto:ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 2:24 PM
To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

 

Oh btw, this is in connect 4.2


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579572.html

To start a new topic under CONNECT Developers, email [hidden email]
To unsubscribe from CONNECT Forums, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
OK, cloning now


On Wed, May 14, 2014 at 12:17 PM, matt w [via CONNECT Forums] <[hidden email]> wrote:

Can you submit a patch with your proposed change in github? (https://github.com/CONNECT-Solution/CONNECT, submit the pull request to the CONNECT_integration branch). I agree with you in principal but Im a little fuzzy on where this is happening… I don’t believe a main() method would be called in any of our classes…

 

From: Daniel Kaplan [via CONNECT Forums] [mailto:[hidden email][hidden email]]
Sent: Wednesday, May 14, 2014 2:24 PM
To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

 

Oh btw, this is in connect 4.2


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579572.html

To start a new topic under CONNECT Developers, email [hidden email]
To unsubscribe from CONNECT Forums, click here.
NAML




If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579573.html
To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



--
Thanks,
Dan

CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782
Reply | Threaded
Open this post in threaded view
|

RE: NwHIN PD can have invalid creation time

matt w
I merged both pull requests. Thanks for you help with this!

From: Daniel Kaplan [via CONNECT Forums] [ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 4:53 PM
To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782


If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579575.html
To start a new topic under CONNECT Developers, email ml-node+[hidden email]
To unsubscribe from CONNECT Forums, click here.
NAML
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Thanks, when will the build be available to use? 


On Wed, May 14, 2014 at 5:53 PM, matt w [via CONNECT Forums] <[hidden email]> wrote:
I merged both pull requests. Thanks for you help with this!

From: Daniel Kaplan [via CONNECT Forums] [ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 4:53 PM

To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782


If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579575.html
To start a new topic under CONNECT Developers, email ml-node+[hidden email]
To unsubscribe from CONNECT Forums, click here.
NAML



If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579576.html
To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



--
Thanks,
Dan

CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.
Reply | Threaded
Open this post in threaded view
|

RE: NwHIN PD can have invalid creation time

matt w

Hi Daniel,

 

We recently released a 4.2.2 patch fix for one of the federal partners but I suspect they would be interested the changes you already submitted, as well as new one(s?) that seems to already be coming up. From that perspective I’ll volunteer to build 4.2.3 tag/binaries once you are confident that you don’t have any more findings from HeW testing. What do you think?

 

From: Daniel Kaplan [via CONNECT Forums] [mailto:ml-node+[hidden email]]
Sent: Thursday, May 15, 2014 12:50 PM
To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

 

Thanks, when will the build be available to use? 

 

On Wed, May 14, 2014 at 5:53 PM, matt w [via CONNECT Forums] <[hidden email]> wrote:

I merged both pull requests. Thanks for you help with this!


From: Daniel Kaplan [via CONNECT Forums] [ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 4:53 PM


To: Weaver, Matthew (CGI Federal)

Subject: Re: NwHIN PD can have invalid creation time

OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579575.html

To start a new topic under CONNECT Developers, email ml-node+[hidden email]

To unsubscribe from CONNECT Forums, click here.
NAML

 


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579576.html

To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



 

--
Thanks,
Dan


CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579577.html

To start a new topic under CONNECT Developers, email [hidden email]
To unsubscribe from CONNECT Forums, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Sounds good to me.  The last one I know about is that new one. 


On Thu, May 15, 2014 at 11:17 AM, matt w [via CONNECT Forums] <[hidden email]> wrote:

Hi Daniel,

 

We recently released a 4.2.2 patch fix for one of the federal partners but I suspect they would be interested the changes you already submitted, as well as new one(s?) that seems to already be coming up. From that perspective I’ll volunteer to build 4.2.3 tag/binaries once you are confident that you don’t have any more findings from HeW testing. What do you think?

 

From: Daniel Kaplan [via CONNECT Forums] [mailto:[hidden email][hidden email]]
Sent: Thursday, May 15, 2014 12:50 PM


To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

 

Thanks, when will the build be available to use? 

 

On Wed, May 14, 2014 at 5:53 PM, matt w [via CONNECT Forums] <[hidden email]> wrote:

I merged both pull requests. Thanks for you help with this!


From: Daniel Kaplan [via CONNECT Forums] [ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 4:53 PM


To: Weaver, Matthew (CGI Federal)

Subject: Re: NwHIN PD can have invalid creation time

OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579575.html

To start a new topic under CONNECT Developers, email ml-node+[hidden email]

To unsubscribe from CONNECT Forums, click here.
NAML

 


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579576.html

To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



 

--
Thanks,
Dan


CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579577.html

To start a new topic under CONNECT Developers, email [hidden email]

To unsubscribe from CONNECT Forums, click here.
NAML




If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579582.html
To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



--
Thanks,
Dan

CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
In reply to this post by matt w
OK I fixed the last one.  


On Thu, May 15, 2014 at 11:20 AM, Dan Kaplan <[hidden email]> wrote:
Sounds good to me.  The last one I know about is that new one. 


On Thu, May 15, 2014 at 11:17 AM, matt w [via CONNECT Forums] <[hidden email]> wrote:

Hi Daniel,

 

We recently released a 4.2.2 patch fix for one of the federal partners but I suspect they would be interested the changes you already submitted, as well as new one(s?) that seems to already be coming up. From that perspective I’ll volunteer to build 4.2.3 tag/binaries once you are confident that you don’t have any more findings from HeW testing. What do you think?

 

From: Daniel Kaplan [via CONNECT Forums] [mailto:[hidden email][hidden email]]
Sent: Thursday, May 15, 2014 12:50 PM


To: Weaver, Matthew (CGI Federal)
Subject: Re: NwHIN PD can have invalid creation time

 

Thanks, when will the build be available to use? 

 

On Wed, May 14, 2014 at 5:53 PM, matt w [via CONNECT Forums] <[hidden email]> wrote:

I merged both pull requests. Thanks for you help with this!


From: Daniel Kaplan [via CONNECT Forums] [ml-node+[hidden email]]
Sent: Wednesday, May 14, 2014 4:53 PM


To: Weaver, Matthew (CGI Federal)

Subject: Re: NwHIN PD can have invalid creation time

OK i created a pull request here.  Let me know if you have any questions: https://github.com/CONNECT-Solution/CONNECT/pull/782


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579575.html

To start a new topic under CONNECT Developers, email ml-node+[hidden email]

To unsubscribe from CONNECT Forums, click here.
NAML

 


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579576.html

To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



 

--
Thanks,
Dan


CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.


If you reply to this email, your message will be added to the discussion below:

http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579577.html

To start a new topic under CONNECT Developers, email [hidden email]

To unsubscribe from CONNECT Forums, click here.
NAML




If you reply to this email, your message will be added to the discussion below:
http://connect-forums.3294226.n2.nabble.com/NwHIN-PD-can-have-invalid-creation-time-tp7579571p7579582.html
To unsubscribe from NwHIN PD can have invalid creation time, click here.
NAML



--
Thanks,
Dan



--
Thanks,
Dan

CONFIDENTIALITY NOTICE: The information contained in this electronic transmission may be confidential. If you are not an intended recipient, be aware that any disclosure, copying, distribution or use of the information contained in this transmission is prohibited and may be unlawful. If you have received this transmission in error, please notify us by email reply and then erase it from your computer system.
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Would it be possible to get 4.2.3 built now?  Thanks
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Was this build ever created?  Thanks a lot
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Naresh Subramanyan
Your fix is part of the 4.2.2.1 release. You can find the binaries from the link ftp://ftp.connectopensource.org/connect_4.0/4.2.2.1/.

Thanks,
Naresh
CONNECT Product Team
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Daniel Kaplan
Hi Nareshcgi,

We installed 4.2.2.1 but we still experienced the same issue: The inbound PD we responded with had this in it:  

<creationTime value="201491221422"/>

It should have this:

<creationTime value="2014091221422"/>

Notice the 0 before the 9.  
Reply | Threaded
Open this post in threaded view
|

Re: NwHIN PD can have invalid creation time

Naresh Subramanyan
I just verified, your code changes are there in the 4.2.2.1 binary, open up the HL7DbParser201306 class file using a Java Decompiler, you will see the changes. Try to put break point on this class and see why its not generating the value correctly. I will update you if I find something from my side.

Thanks,
Naresh
CONNECT Product Team